Conversation
Signed-off-by: hayleycd <cook.hayley@gmail.com>
✅ Deploy Preview for docssigstore ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: hayleycd <cook.hayley@gmail.com>
Signed-off-by: hayleycd <cook.hayley@gmail.com>
| verify-oidc-issuer: https://token.actions.githubusercontent.com | ||
| ``` | ||
|
|
||
| ## Using Cosign within your CI system |
There was a problem hiding this comment.
Do we prefer to only feature container signing for the cosign-installer section, since we've already signed and verified a blob with the python action?
There was a problem hiding this comment.
I think both are fine to feature. Could we flip the order so container signing is first?
There was a problem hiding this comment.
@haydentherapper Done! Please review changes.
| verify-oidc-issuer: https://token.actions.githubusercontent.com | ||
| ``` | ||
|
|
||
| ## Using Cosign within your CI system |
There was a problem hiding this comment.
I think both are fine to feature. Could we flip the order so container signing is first?
|
cc @woodruffw if you have any comments about the gha usage |
Signed-off-by: hayleycd <cook.hayley@gmail.com>
Signed-off-by: hayleycd <cook.hayley@gmail.com>
Signed-off-by: hayleycd <cook.hayley@gmail.com>
Signed-off-by: hayleycd <cook.hayley@gmail.com>
|
@woodruffw thanks for your review! I like your changes and I learned something new about permissions in GitHub Actions. @haydentherapper I made the changes @woodruffw suggested and this is ready for you to take another look when you have time. |
Hayden-IO
left a comment
Hayden-IO
left a comment
There was a problem hiding this comment.
Thanks! And thanks @woodruffw for the review!
3 participants
Summary
Partially resolves #354 . Adds a quickstart for CI.
Release Note
NONE